From f1c74cb036a4cdbe9de735f5594a676009b3d7b5 Mon Sep 17 00:00:00 2001
From: Dorian Niemiec <dorian.niemiec@svrjs.org>
Date: Sun, 17 Mar 2024 00:57:47 +0100
Subject: [PATCH] Optimized bad (broken) entry generation in directory listing

---
 svr.js | 28 +++++++++-------------------
 1 file changed, 9 insertions(+), 19 deletions(-)

diff --git a/svr.js b/svr.js
index 14c9211..3cfe581 100644
--- a/svr.js
+++ b/svr.js
@@ -3703,25 +3703,15 @@ if (!cluster.isPrimary) {
                           var estats = filelist[i].stats;
                           var ename = filelist[i].name;
                           if (filelist[i].errored) {
-                            if (estats) {
-                              directoryListingRows.push(
-                                "<tr><td style=\"width: 24px;\"><img src=\"/.dirimages/bad.png\" alt=\"[BAD]\" width=\"24px\" height=\"24px\" /></td><td style=\"word-wrap: break-word; word-break: break-word; overflow-wrap: break-word;\"><a href=\"" +
-                                (href + "/" + encodeURI(ename)).replace(/\/+/g, "/") +
-                                "\"><nocode>" +
-                                ename.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;") +
-                                "</nocode></a></td><td>-</td><td>" +
-                                estats.mtime.toDateString() +
-                                "</td></tr>\r\n"
-                              );
-                            } else {
-                              directoryListingRows.push(
-                                "<tr><td style=\"width: 24px;\"><img src=\"/.dirimages/bad.png\" alt=\"[BAD]\" width=\"24px\" height=\"24px\" /></td><td style=\"word-wrap: break-word; word-break: break-word; overflow-wrap: break-word;\"><a href=\"" +
-                                (href + "/" + encodeURI(ename)).replace(/\/+/g, "/") +
-                                "\"><nocode>" +
-                                ename.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;") +
-                                "</nocode></a></td><td>-</td><td>-</td></tr>\r\n"
-                              );
-                            }
+                            directoryListingRows.push(
+                              "<tr><td style=\"width: 24px;\"><img src=\"/.dirimages/bad.png\" alt=\"[BAD]\" width=\"24px\" height=\"24px\" /></td><td style=\"word-wrap: break-word; word-break: break-word; overflow-wrap: break-word;\"><a href=\"" +
+                              (href + "/" + encodeURI(ename)).replace(/\/+/g, "/") +
+                              "\"><nocode>" +
+                              ename.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;") +
+                              "</nocode></a></td><td>-</td><td>" +
+                              (estats ? estats.mtime.toDateString() : "-") +
+                              "</td></tr>\r\n"
+                            );
                           } else {
                             var entry = "<tr><td style=\"width: 24px;\"><img src=\"[img]\" alt=\"[alt]\" width=\"24px\" height=\"24px\" /></td><td style=\"word-wrap: break-word; word-break: break-word; overflow-wrap: break-word;\"><a href=\"" +
                               (origHref + "/" + encodeURIComponent(ename)).replace(/\/+/g, "/") +