From 3b4fd9641cc111279cc67a19256d7ceb6b4a52c6 Mon Sep 17 00:00:00 2001
From: Dorian Niemiec <dorian.niemiec@svrjs.org>
Date: Thu, 29 Aug 2024 19:05:02 +0200
Subject: [PATCH] Change blocklist-related commands to use .forEach() function
 instead of a for loop

---
 src/middleware/blocklist.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/middleware/blocklist.js b/src/middleware/blocklist.js
index 020166f..fa7d294 100644
--- a/src/middleware/blocklist.js
+++ b/src/middleware/blocklist.js
@@ -23,14 +23,14 @@ module.exports.commands = {
     if (ip == undefined || JSON.stringify(ip) == "[]") {
       if (!cluster.isPrimary === false) log("Cannot block non-existent IP.");
     } else {
-      for (var i = 0; i < ip.length; i++) {
-        if (ip[i] != "localhost" && ip[i].indexOf(":") == -1) {
-          ip[i] = "::ffff:" + ip[i];
+      ip.forEach((ipAddress) => {
+        if (ipAddress !== "localhost" && ipAddress.indexOf(":") == -1) {
+          ipAddress = "::ffff:" + ipAddress;
         }
-        if (!blocklist.check(ip[i])) {
-          blocklist.add(ip[i]);
+        if (!blocklist.check(ipAddress)) {
+          blocklist.add(ipAddress);
         }
-      }
+      });
       process.serverConfig.blacklist = blocklist.raw;
       if (!cluster.isPrimary === false) log("IPs successfully blocked.");
       passCommand(ip, log);
@@ -40,12 +40,12 @@ module.exports.commands = {
     if (ip == undefined || JSON.stringify(ip) == "[]") {
       if (!cluster.isPrimary === false) log("Cannot unblock non-existent IP.");
     } else {
-      for (var i = 0; i < ip.length; i++) {
-        if (ip[i].indexOf(":") == -1) {
-          ip[i] = "::ffff:" + ip[i];
+      ip.forEach((ipAddress) => {
+        if (ipAddress !== "localhost" && ipAddress.indexOf(":") == -1) {
+          ipAddress = "::ffff:" + ipAddress;
         }
-        blocklist.remove(ip[i]);
-      }
+        blocklist.remove(ipAddress);
+      });
       process.serverConfig.blacklist = blocklist.raw;
       if (!cluster.isPrimary === false) log("IPs successfully unblocked.");
       passCommand(ip, log);