DorianNiemiecSVRJS/svrjs
Archived
1
0
Fork 0
forked from svrjs/svrjs
Code Pull requests Activity

Improve protection against user enumeration

Browse source
This commit is contained in:
Dorian Niemiec 2024-03-17 10:17:53 +01:00
parent 184060fb79
commit 32a92804fa
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
svr.js
View file

@ -4646,18 +4646,36 @@ if (!cluster.isPrimary) {
var username = decodedCredentialsMatch[1]; var username = decodedCredentialsMatch[1];
var password = decodedCredentialsMatch[2]; var password = decodedCredentialsMatch[2];
var usernameMatch = []; var usernameMatch = [];
var sha256Count = 0;
var pbkdf2Count = 0;
var scryptCount = 0;
if (!authcode.userList || authcode.userList.indexOf(username) > -1) { if (!authcode.userList || authcode.userList.indexOf(username) > -1) {
usernameMatch = users.filter(function (entry) { usernameMatch = users.filter(function (entry) {
if(entry.pbkdf2) {
pbkdf2Count++;
} else if(entry.scrypt) {
scryptCount++;
} else {
sha256Count++;
}
return entry.name == username; return entry.name == username;
}); });
} }
if (usernameMatch.length == 0) { if (usernameMatch.length == 0) {
// Pushing false user match to prevent time-based user enumeration // Pushing false user match to prevent time-based user enumeration
usernameMatch.push({ var fakeCredentials = {
name: username, name: username,
pass: "SVRJSAWebServerRunningOnNodeJS", pass: "SVRJSAWebServerRunningOnNodeJS",
salt: "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0" salt: "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0"
}); // Fake credentials };
if (!process.isBun) {
if (pbkdf2Count > sha256Count && pbkdf2Count > scryptCount) {
fakeCredentials.pbkdf2 = true;
} else if (scryptCount > sha256Count) {
fakeCredentials.scrypt = true;
}
}
usernameMatch.push(fakeCredentials);
} }
checkIfPasswordMatches(usernameMatch, password, function (authorized) { checkIfPasswordMatches(usernameMatch, password, function (authorized) {
try { try {